Skip to content

Change the remote feature flag for UI load instrumentation#2111

Merged
bidetofevil merged 1 commit intomainfrom
hho/ui-load-killswitch-v2
Apr 23, 2025
Merged

Change the remote feature flag for UI load instrumentation#2111
bidetofevil merged 1 commit intomainfrom
hho/ui-load-killswitch-v2

Conversation

@bidetofevil
Copy link
Copy Markdown
Contributor

@bidetofevil bidetofevil commented Apr 23, 2025 •
edited
Loading

Goal

Change to new feature flag that defaults to "true", which will now match the client default

@bidetofevil bidetofevil requested a review from a team as a code owner April 23, 2025 17:28
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 23, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@bidetofevil Graphite App
Copy link
Copy Markdown
Contributor Author

bidetofevil commented Apr 23, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@bidetofevil bidetofevil requested a review from priettt April 23, 2025 17:30
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 23, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.34%. Comparing base (07035a7) to head (d3f5063).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2111   +/-   ##
=======================================
  Coverage   85.33%   85.34%           
=======================================
  Files         470      470           
  Lines       10578    10578           
  Branches     1564     1564           
=======================================
+ Hits         9027     9028    +1     
  Misses        870      870           
+ Partials      681      680    -1
Files with missing lines Coverage Δ
.../embracesdk/internal/config/remote/RemoteConfig.kt 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bidetofevil Graphite App
Copy link
Copy Markdown
Contributor Author

bidetofevil commented Apr 23, 2025 •
edited
Loading

Merge activity

  • Apr 23, 2:56 PM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Apr 23, 2:56 PM EDT: A user merged this pull request with Graphite.

@bidetofevil bidetofevil merged commit 8f23c7c into main Apr 23, 2025
11 of 12 checks passed
@bidetofevil bidetofevil deleted the hho/ui-load-killswitch-v2 branch April 23, 2025 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@priettt priettt priettt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bidetofevil @priettt